On Mon, 2011-10-10 at 08:54 +0200, Jan Kiszka wrote:
> On 2011-10-09 20:52, Vadim Rozenfeld wrote:
> > ---
> >  qemu-options.hx |   23 +++++++++++++++++++++++
> >  vl.c            |    2 ++
> >  2 files changed, 25 insertions(+), 0 deletions(-)
> > 
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 3a13533..9f60059 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -2483,6 +2483,29 @@ DEF("kvm-shadow-memory", HAS_ARG, 
> > QEMU_OPTION_kvm_shadow_memory,
> >      "                allocate MEGABYTES for kvm mmu shadowing\n",
> >      QEMU_ARCH_I386)
> >  
> > +DEF("hyperv", HAS_ARG, QEMU_OPTION_hyperv,
> > +    "-hyperv [vapic=on|off][,spinlock=retries][,wd=on|off]\n"
> > +    "                enable Hyper-V Enlightenment\n",
> > +        QEMU_ARCH_ALL)
> 
> These are CPU feature, so -cpu +/-hv_vapic,+/-hv_spinlock etc. looks
> more appropriate than a new command line parameter.
> 
I would like to keep hyper-v settings apart from cpu features for a very
simple reason: if hyper-v VMBus support will be added one day, it won't
be a CPU only feature anymore.   
> BTW, documentation and maybe also option processing should make clear
> that this is limited to KVM mode for now.
> 
Will add it.
Vadim
> Jan
> 


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to