On 2016-09-13 00:51, Andriy Rysin wrote: > All language tests passed but as it's a core rule used by many I'd > like to do a review before I push.
+ // short for SENT_START + if( StringUtils.isEmpty(tokenReadings.getToken()) ) + continue; I suggest you explicitly check for SENT_START here instead of white space. + ArrayList<String> lemmas = new ArrayList<>(); It's better to use List<String> lemmas = new ArrayList<>(); Other than that I don't see a problem, but I don't have time for a deep code review. Feel free to just commit, we usually have enough tests to catch issues. Regards Daniel ------------------------------------------------------------------------------ _______________________________________________ Languagetool-devel mailing list Languagetool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/languagetool-devel
