Hi,
> 11. > Stop! I see that I'm using an old lcms.h file!? > :-) There is however a small error, on returning false instead of NULL. As I can see, CodeWarrior mostly complains about strict typechecking. I do assume that a void* pointer will be compatible with any pointer, wich seems not to be the case on CodeWarrior. Of course these are not bad news, but very good news instead.... Codewarrior wasn't supported on anterior revision, and seems there is a chance for this one. I did check ver 1.09 on OSX, but using gcc. So, it is very good to get yet another compiler supported. And CodeWarrior is a very extended compiler, indeed. I'm putting all typecasts in sources, probably I will release a minor revision when all possible problems has became evident. > Fixed32 FixedSquare(Fixed32 a) > void VEC3scaleAndCut(LPWVEC3 r, LPVEC3 v, double d) > void MAT3scaleAndCut(LPWMAT3 r, LPMAT3 v, double d) These are not used anymore outside its module. I keep the functions as global just for compatibility sake. About unlink() and swab(), well, unlink() does delete a file. Is Unix/POSIX defined function. its ANSI equivalent is remove(). if the compiler does not support swab, then there is a toggle on lcms.h to use the replacement instead. (see USE_CUSTOM_SWAB on lcms.h) Many thanks for your report! Regards, Mart� Maria The little cms project http://www.littlecms.com [EMAIL PROTECTED] ----- Original Message ----- From: "Christian Schmitz" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Cc: "Mart� Maria" <[EMAIL PROTECTED]> Sent: Wednesday, July 10, 2002 6:19 PM Subject: [Lcms-user] Compiling 109 using Codewarrior > Hi, > > I've downloaded the 109a version as a zip file and I'm trying to compile > it for Mac OS X, Mac OS Classic and Windows, but I've some things, you > may change to your sources to let it better compile. > (without me changing it everytime) > > 1. > Need function prototype for: (compile error) > > LPSAMPLEDCURVE cmsConvertGammaToSampledCurve(LPGAMMATABLE Gamma, int > nPoints) > LPGAMMATABLE cmsConvertSampledCurveToGamma(LPSAMPLEDCURVE Sampled, > double Max) > > 2. > Need function prototype for: (compile warning) > > LPSAMPLEDCURVE cmsDupSampledCurve(LPSAMPLEDCURVE p) > double LCMSEXPORT cmsCIE94DeltaE(LPcmsCIELab Lab1, LPcmsCIELab Lab2) > double LCMSEXPORT cmsBFDdeltaE(LPcmsCIELab Lab1, LPcmsCIELab Lab2) > double LCMSEXPORT cmsCMCdeltaE(LPcmsCIELab Lab1, LPcmsCIELab Lab2) > LPLUT _cmsComputeSoftProofLUT(cmsHPROFILE hProfile, int nIntent) > BOOL LCMSEXPORT cmsTakeCharTargetData(cmsHPROFILE hProfile, char** Data, > size_t* len) > > 3. > Compile errors: > > case PT_HiFi: return icSigHexachromeData; > must be; > case PT_HiFi: return (icColorSpaceSignature)icSigHexachromeData; > > 4. > InitTag(Icc, icSigProfileDescriptionTag, 11, "(internal)"); > must be: > InitTag(Icc, icSigProfileDescriptionTag, 11, > (void* const)&"(internal)"); > > 5. > Inside > cmsHPROFILE LCMSEXPORT cmsCreateRGBProfile(LPcmsCIExyY WhitePoint, > LPcmsCIExyYTRIPLE Primaries, > LPGAMMATABLE TransferFunction[3]) > there is a "return false", which may better be a "return NULL". > > 6. > What is LOGE? > > return (54.6 * (LOGE * (log(yt + 1.5))) - 9.6); > > 7. > What is unlink? > unlink(TempFileLocation); > > 8. > What is MAT3fromFix? > MAT3fromFix(&Original, &Lut->Matrix); > Later: > Add prototype to let the compiler compile: > void MAT3fromFix(LPMAT3 r, LPWMAT3 v); > > 9. > Inside > LPGAMMATABLE cmsReadICCGamma(cmsHPROFILE hProfile, icTagSignature sig) > return DupGamma(Icc -> TagPtrs[n]); > must be: > return DupGamma((GAMMATABLE*) Icc -> TagPtrs[n]); > > 10. > Header.deviceClass = TransportValue32(Icc -> DeviceClass); > Header.colorSpace = TransportValue32(Icc -> ColorSpace); > Header.pcs = TransportValue32(Icc -> PCS); > must be: > Header.deviceClass = > (icProfileClassSignature)TransportValue32(Icc -> DeviceClass); > Header.colorSpace = > (icColorSpaceSignature)TransportValue32(Icc -> ColorSpace); > Header.pcs = > (icColorSpaceSignature)TransportValue32(Icc -> PCS); > > 10. > inside > static BOOL SetupBase(FILE *OutStream, icTagTypeSignature sig) > Base.sig = TransportValue32(sig); > must be: > Base.sig = (icTagTypeSignature)TransportValue32(sig); > > 11. > Stop! I see that I'm using an old lcms.h file!? > > 12. > Put on the top of lcms.h, so the Windows stuff is kept out: > > #if TARGET_CPU_PPC > #define NON_WINDOWS 1 > #endif > > 13. > Header.platform = > TransportValue32(icSigMicrosoft); > // Sorry, I must put something here > must be: > Header.platform = > (icPlatformSignature)TransportValue32(icSigMicrosoft); > // Sorry, I must put something here > > 14. unlink still missing. > > 15. > Tag.sig = TransportValue32(Icc -> TagNames[i]); > Tag.offset = TransportValue32(Icc -> TagOffsets[i]); > Tag.size = TransportValue32(Icc -> TagSizes[i]); > must be: > Tag.sig = (icTagSignature)TransportValue32(Icc -> > TagNames[i]); > Tag.offset = TransportValue32(Icc -> TagOffsets[i]); > Tag.size = TransportValue32(Icc -> TagSizes[i]); > > 16. > p = cmsCreateTransform(NULL, InputFormat, NULL, OutputFormat, > Intent, cmsFLAGS_NULLTRANSFORM); > must be: > p = (_LPcmsTRANSFORM)cmsCreateTransform(NULL, InputFormat, NULL, > OutputFormat, Intent, cmsFLAGS_NULLTRANSFORM); > > 17. Compiles for Mac OS Classic with unlink commented out. > > 18. Missing propotypes for: > Fixed32 FixedSquare(Fixed32 a) > void VEC3scaleAndCut(LPWVEC3 r, LPVEC3 v, double d) > void MAT3scaleAndCut(LPWMAT3 r, LPMAT3 v, double d) > > 19. Compiles for Mac OS Carbon with unlink commented out. > > 20. xswab is not declared, but used in cmsio1.c: > > So "#define USE_CUSTOM_SWAB 1" must be on here for Windows compiles. > > 21. Compiles for Windows. > > Mfg > Christian > > -- > There are only three types of computer users: > Those that use Macs. > Those that wished they used Macs. > Those that don't know any better. > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Two, two, TWO treats in one. > http://thinkgeek.com/sf > _______________________________________________ > Lcms-user mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/lcms-user > > ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek PC Mods, Computing goodies, cases & more http://thinkgeek.com/sf _______________________________________________ Lcms-user mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/lcms-user
