Am Mittwoch, 14. September 2011, 09:03:08 schrieb Erich Titl: > Hi Folks > > I have recently been running a few time into an issue with > buildtool which probably bothers not only me. > > from any average buildtool.mk > > SMARTMON_DIR:=smartmontools-5.36 > SMARTMON_TARGET_DIR:=$(BT_BUILD_DIR)/smartmon > > $(SMARTMON_DIR)/.source: > zcat $(SMARTMON_SOURCE) | tar -xvf - > touch $(SMARTMON_DIR)/.source > > source: $(SMARTMON_DIR)/.source > ..... > > clean: > make -C $(SMARTMON_DIR) clean > rm -rf $(SMARTMON_TARGET_DIR) > rm -f $(SMARTMON_DIR)/.build > rm -f $(SMARTMON_DIR)/.configured > > > srcclean: clean > rm -rf $(SMARTMON_DIR) > rm -f $(SMARTMON_DIR)/.source > > Now if someone just removes SMARTMON_DIR this will lead to > buildtool failures when calling buildclean or srcclean. > > This is not necessary. It can be easily avoided by _not_ placing > the .source, .configured and .build flags in the respective > directories. They are not really a part of the unpacked code and > IMHO should not be tampered with. > > I suggest to use > > .source: > zcat $(SMARTMON_SOURCE) | tar -xvf - > touch .source > > source: .source > > instead, as already done in a few cases.
Hi Erich; good suggestion! Every "leaf-developer" should be able to commit changes to git, if he'll see such a flaw in a package. low hanging fruits :) kp ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA Learn about the latest advances in developing for the BlackBerry® mobile platform with sessions, labs & more. See new tools and technologies. Register for BlackBerry® DevCon today! http://p.sf.net/sfu/rim-devcon-copy1 _______________________________________________ leaf-devel mailing list leaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/leaf-devel
