On 8/30/07, Bryan Kadzban <[EMAIL PROTECTED]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: RIPEMD160 > > Jeremy Huntwork wrote: > > On Thu, Aug 30, 2007 at 07:32:53PM +0200, M.Canales.es wrote: > >> I agree, at least as a starting point for 7.0 milestone. Some plans > >> to start merging jh branch into trunk? > > > > I would like to get it in as soon as we can, but considering that > > there are a number of changes, I was hoping that more people would > > have had time to look at the branch and comment before we merge. For > > quick reference again, here's the rendered book: > > > > http://linuxfromscratch.org/~jhuntwork/lfs-JH/ > > > > and a diff between it and trunk: > > > > http://linuxfromscratch.org/~jhuntwork/jh.diff > > I've been reading through the diff, and I saw this in binutils-pass1: > > +<screen><userinput>test $(uname -m | grep 64) && > M64="-m64"</userinput></screen> > > Why not just: > > uname -m | grep -q 64 && M64="-m64" > > instead? The -q option to grep will prevent any output, and just return > an appropriate exit code.
Except that you're still using the host grep, which may not have the -q option (don't remember when it was added). grep 64 >/dev/null works, too. I also was thinking that you would want to do `|| M64=""' in case there was a stray M64 variable in the environment, but maybe that's too paranoid. > Also, I see that the console log level change hasn't been merged into > the jh branch either (that was r8222, and perhaps a few revs around it > also -- chapter07/console.xml). It seems to also be missing a udev-config fix to handle usb devices in 2.6.22+ kernels. -- Dan -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
