Hi,
On Tue, Dec 04, 2007, Lionel Debroux wrote:
> I sent three patches last week, and the third one inadvertently
> inclued an unrelated change which broke compilation... Here is an
> updated version, and four more patches (even less warnings, a number
> of Doxygen comments, etc.). The Doxygen comments will help for the
> project I'm involved in.
Thanks for your efforts; I don't have commit access to libmpeg2, but
had a look at your patches (for inclusion in Debian); here's my review:
- 0001-PPC-compilation-fixes-from-MPlayer-SVN-repo-revisi: looks good
(only interesting for OSX)
- 0002-Fix-crash-with-http-sam.zoy.org-zzuf-lol-mplayer.m: doesn't look
too dangerous; there are unrelated indentation changes (tabs versus
spaces), and there are two different fixes in the file; as I'm not
sure which one fixes our Debian bug, I'm going to pull both; I can't
tell whether the changes have any performance impact
- 0003-Fix-some-of-the-warnings-with-increased-warning-sett: looks
good, mostly addresses warnings
- 0004-Move-add-file-function-variable-descriptions: looks good too,
probably mostly helps doxygen
- 0005-Fix-some-of-the-warnings-triggered-by-Wwrite-string: looks good,
mostly addresses warnings
- 0006-More-documentation: code indentation and comments for clarity
and some doc
- 0007-Constify-variable-black-in-samples-1-3-5: helps some warnings
and enhances a debug log
The only one I'm going to take for Debian is probably 0002, but the
others seem fine to be committed in libmpeg2 upstream to me.
Bye,
--
Loïc Minier
-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Libmpeg2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/libmpeg2-devel
