https://bugs.documentfoundation.org/show_bug.cgi?id=63416

--- Comment #12 from i...@scito.ch ---
Created attachment 114181
  --> https://bugs.documentfoundation.org/attachment.cgi?id=114181&action=edit
Code parts responsible for current behaviour

Thanks for your explanation according to priorities. Since there is a
workaround (fill empty column headers with a space) the priority is minor.

I've analysed the code by using the online git view since I do not have a LibO
development environment.

Basically, the following lines of code are responsible for the current
behaviour:

void ScGridWindow::UpdateAutoFilterFromMenu(AutoFilterMode eMode) {
...
bool bHasHeader = pDoc->HasColHeader(
    aSortParam.nCol1, aSortParam.nRow1, aSortParam.nCol2, aSortParam.nRow2,
nTab);

aSortParam.bHasHeader = bHasHeader;

****

bool ScTable::HasColHeader( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol,
SCROW /* nEndRow */ ) const
{
    for (SCCOL nCol=nStartCol; nCol<=nEndCol; nCol++)
    {
        CellType eType = GetCellType( nCol, nStartRow );
        if (eType != CELLTYPE_STRING && eType != CELLTYPE_EDIT)
            return false;
    }
    return true;
}

I've attached the relevant code parts responsible for autofilter sorting, see
attachment.

Lacking an IDE, I do not know how often ScTable::HasColHeader is used and what
the impact of a change of this method would be.

This autofilter sorting feature was added with commit
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a755c0cd61b619ed14e023ad34fc7596eafdf34

Currently, I do not know what a correct solution would be.

Additionally, there is a warning dialog shown if the autofilter is applied with
empty cells in the header: "The range does not contain column headers.
Do you want the first line to be used as column header?" This behaviour should
be considered too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to