cppcanvas/source/mtfrenderer/polypolyaction.cxx | 6 +++---
editeng/inc/editdoc.hxx | 2 +-
editeng/source/editeng/editdoc.cxx | 4 ++--
sot/source/sdstor/stgdir.cxx | 3 +--
sot/source/sdstor/stgdir.hxx | 2 +-
5 files changed, 8 insertions(+), 9 deletions(-)
New commits:
commit 8b6c8e624b1257a2221e8f98ba71112eae86c795
Author: Caolán McNamara <caol...@redhat.com>
AuthorDate: Tue Jun 14 08:43:54 2022 +0100
Commit: Caolán McNamara <caol...@redhat.com>
CommitDate: Tue Jun 14 11:37:16 2022 +0200
cid#1504592 Big parameter passed by value
and
cid#1504665 Big parameter passed by value
cid#1505368 Big parameter passed by value
revert the clang-tidy modernize-pass-by-value changes that coverity
warns about
Change-Id: Id92fdc8d1caeed9eaf7ff1e9e745938e5a971a34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135803
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caol...@redhat.com>
diff --git a/cppcanvas/source/mtfrenderer/polypolyaction.cxx
b/cppcanvas/source/mtfrenderer/polypolyaction.cxx
index 14ae52d8b2cf..7f499be1ebe0 100644
--- a/cppcanvas/source/mtfrenderer/polypolyaction.cxx
+++ b/cppcanvas/source/mtfrenderer/polypolyaction.cxx
@@ -227,7 +227,7 @@ namespace cppcanvas::internal
TexturedPolyPolyAction( const ::basegfx::B2DPolyPolygon& rPoly,
const CanvasSharedPtr&
rCanvas,
const OutDevState&
rState,
- rendering::Texture
aTexture );
+ const rendering::Texture&
rTexture );
virtual bool renderSubset( const ::basegfx::B2DHomMatrix&
rTransformation,
const Subset&
rSubset ) const override;
@@ -255,12 +255,12 @@ namespace cppcanvas::internal
TexturedPolyPolyAction::TexturedPolyPolyAction( const
::basegfx::B2DPolyPolygon& rPolyPoly,
const
CanvasSharedPtr& rCanvas,
const OutDevState&
rState,
- rendering::Texture
aTexture ) :
+ const
rendering::Texture& rTexture ) :
CachedPrimitiveBase( rCanvas, true ),
mxPolyPoly(
::basegfx::unotools::xPolyPolygonFromB2DPolyPolygon(
rCanvas->getUNOCanvas()->getDevice(), rPolyPoly) ),
maBounds( ::basegfx::utils::getRange(rPolyPoly) ),
mpCanvas( rCanvas ),
- maTexture(std::move( aTexture ))
+ maTexture( rTexture )
{
tools::initRenderState(maState,rState);
}
diff --git a/editeng/inc/editdoc.hxx b/editeng/inc/editdoc.hxx
index 12532fde7e73..6ce00d05c40b 100644
--- a/editeng/inc/editdoc.hxx
+++ b/editeng/inc/editdoc.hxx
@@ -244,7 +244,7 @@ private:
public:
ContentNode( SfxItemPool& rItemPool );
- ContentNode( OUString aStr, ContentAttribs aContentAttribs
);
+ ContentNode( const OUString& rStr, const ContentAttribs&
rContentAttribs );
~ContentNode();
ContentNode(const ContentNode&) = delete;
ContentNode& operator=(const ContentNode&) = delete;
diff --git a/editeng/source/editeng/editdoc.cxx
b/editeng/source/editeng/editdoc.cxx
index 7621f7c0cd3f..41a8cf20f1b8 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -1193,8 +1193,8 @@ ContentNode::ContentNode( SfxItemPool& rPool ) :
aContentAttribs( rPool )
{
}
-ContentNode::ContentNode( OUString aStr, ContentAttribs _aContentAttribs ) :
- maString(std::move(aStr)), aContentAttribs(std::move(_aContentAttribs))
+ContentNode::ContentNode( const OUString& rStr, const ContentAttribs&
rContentAttribs ) :
+ maString(rStr), aContentAttribs(rContentAttribs)
{
}
diff --git a/sot/source/sdstor/stgdir.cxx b/sot/source/sdstor/stgdir.cxx
index ee70d390542e..69ca094f370f 100644
--- a/sot/source/sdstor/stgdir.cxx
+++ b/sot/source/sdstor/stgdir.cxx
@@ -28,7 +28,6 @@
#include <sal/log.hxx>
#include <memory>
-#include <utility>
//////////////////////////// class StgDirEntry
@@ -53,7 +52,7 @@ StgDirEntry::StgDirEntry( const void* pBuffer, sal_uInt32
nBufferLen, sal_uInt64
InitMembers();
}
-StgDirEntry::StgDirEntry( StgEntry r ) : m_aEntry(std::move( r ))
+StgDirEntry::StgDirEntry( const StgEntry& r ) : m_aEntry( r )
{
InitMembers();
}
diff --git a/sot/source/sdstor/stgdir.hxx b/sot/source/sdstor/stgdir.hxx
index 5044dc48f313..3605c27ac03d 100644
--- a/sot/source/sdstor/stgdir.hxx
+++ b/sot/source/sdstor/stgdir.hxx
@@ -59,7 +59,7 @@ public:
bool m_bInvalid; // true: invalid entry
StgDirEntry(const void* pBuffer, sal_uInt32 nBufferLen,
sal_uInt64 nUnderlyingStreamSize, bool * pbOk);
- explicit StgDirEntry( StgEntry );
+ explicit StgDirEntry( const StgEntry& );
virtual ~StgDirEntry() override;
void Invalidate( bool ); // invalidate all open entries
