[Libreoffice-commits] core.git: basic/source

[Caolán McNamara (via logerrit)]

 basic/source/sbx/sbxform.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit d28ba797dfb804e020e1cd8be5505f31b2adb74a
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Jul 23 10:55:28 2023 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sun Jul 23 15:04:29 2023 +0200

    nDigitPos no longer appears in expression
    
    so presumably we no longer need this suppression since:
    
    commit d969715fa4df9de762c652a7af27601fa75fb275
    Date:   Wed Jul 19 22:29:35 2023 +0200
    
        Simplify a bit by removing a redundant condition
    
        line 627 already contains: if( nMaxDigit > nDigitPos )
    
    Change-Id: If6ff93f91f5bd20a9a03ed828d6f4e598ff4f3da
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154804
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/basic/source/sbx/sbxform.cxx b/basic/source/sbx/sbxform.cxx
index 02bc6a01a8fd..e616a1878910 100644
--- a/basic/source/sbx/sbxform.cxx
+++ b/basic/source/sbx/sbxform.cxx
@@ -634,7 +634,6 @@ void SbxBasicFormater::ScanFormatString( double dNumber,
                             {
                                 bFirstDigit = false;
                             }
-                            // coverity[copy_paste_error : FALSE] - this is 
correct and nDigitPos should not be j
                             if( bGenerateThousandSeparator && c=='0' && j > 0 
&& (j % 3 == 0) )
                             {
                                 sReturnStrg.append(cThousandSep );