sc/source/core/data/dpoutput.cxx | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
New commits:
commit a8a2c49d1984447297085824b593039908498fe5
Author: Tomaž Vajngerl <tomaz.vajng...@collabora.co.uk>
AuthorDate: Tue Feb 27 14:06:40 2024 +0900
Commit: Tomaž Vajngerl <qui...@gmail.com>
CommitDate: Thu Feb 29 08:32:35 2024 +0100
sc: use emplace_back instead of a temporary object and push_back
Change-Id: I5913d760fcfa45eb5162fecf25efa68bc17dcbcc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164037
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <qui...@gmail.com>
diff --git a/sc/source/core/data/dpoutput.cxx b/sc/source/core/data/dpoutput.cxx
index a0e87f19415a..c269e00a3438 100644
--- a/sc/source/core/data/dpoutput.cxx
+++ b/sc/source/core/data/dpoutput.cxx
@@ -598,9 +598,8 @@ ScDPOutput::ScDPOutput(ScDocument* pDocument,
uno::Reference<sheet::XDimensionsS
uno::Sequence<sheet::MemberResult>
aResult = xLevRes->getResults();
if (!lcl_MemberEmpty(aResult))
{
- ScDPOutLevelData tmp(nDim,
nHierarchy, nLev, nDimPos, nNumFmt, aResult, aName,
- aCaption,
bHasHiddenMember, bIsDataLayout, false);
- mpColFields.push_back(tmp);
+ mpColFields.emplace_back(nDim,
nHierarchy, nLev, nDimPos, nNumFmt, aResult, aName,
+ aCaption,
bHasHiddenMember, bIsDataLayout, false);
}
}
break;
@@ -624,9 +623,8 @@ ScDPOutput::ScDPOutput(ScDocument* pDocument,
uno::Reference<sheet::XDimensionsS
catch (uno::Exception&)
{
}
- ScDPOutLevelData tmp(nDim,
nHierarchy, nLev, nDimPos, nNumFmt, aResult, aName,
- aCaption,
bHasHiddenMember, bIsDataLayout, false);
- mpRowFields.push_back(tmp);
+ mpRowFields.emplace_back(nDim,
nHierarchy, nLev, nDimPos, nNumFmt, aResult, aName,
+ aCaption,
bHasHiddenMember, bIsDataLayout, false);
maRowCompactFlags.push_back(bFieldCompact);
mbHasCompactRowField |=
bFieldCompact;
}
@@ -637,9 +635,8 @@ ScDPOutput::ScDPOutput(ScDocument* pDocument,
uno::Reference<sheet::XDimensionsS
{
uno::Sequence<sheet::MemberResult>
aResult = getVisiblePageMembersAsResults(xLevel);
// no check on results for page fields
- ScDPOutLevelData tmp(nDim, nHierarchy,
nLev, nDimPos, nNumFmt, aResult, aName,
- aCaption,
bHasHiddenMember, false, true);
- mpPageFields.push_back(tmp);
+ mpPageFields.emplace_back(nDim,
nHierarchy, nLev, nDimPos, nNumFmt, aResult, aName,
+ aCaption,
bHasHiddenMember, false, true);
}
break;
default:
