sal/osl/w32/file_dirvol.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit e642eec333b9a80b04a9c19290d959de1f0ae5ff
Author: Stephan Bergmann <sberg...@redhat.com>
Date: Mon Aug 20 15:18:35 2012 +0200
fdo#53252: _toupper is unreliable
<http://msdn.microsoft.com/en-us/library/45119yx3%28v=vs.80%29.aspx>
"toupper,
_toupper, towupper, _toupper_l, _towupper_l: Visual Studio 2005" states: "In
order for toupper to give the expected results, __isascii and isupper must
both
return nonzero." But a community comment clarifies: "This is incorrect, and
should refer to '_toupper' (the macro form), not 'toupper'." (Which makes
sense, as otherwise toupper would violate the C Standard.)
And indeed, at least for some LO built against MSVC 2008 Express on Windows
7,
_toupper('C') = '#' is broken, while toupper('C') = 'C' is good. (And the
unexpected '#' then causes all sorts of errors in the code.)
Change-Id: Iddaddcaf0cc3ffb30e55b0f410a6cfe9118accc8
diff --git a/sal/osl/w32/file_dirvol.cxx b/sal/osl/w32/file_dirvol.cxx
index 1a3114f..2736723 100644
--- a/sal/osl/w32/file_dirvol.cxx
+++ b/sal/osl/w32/file_dirvol.cxx
@@ -1117,7 +1117,7 @@ oslFileError SAL_CALL osl_getDirectoryItem(rtl_uString
*strFilePath, oslDirector
osl_acquireDirectoryItem( (oslDirectoryItem)pItemImpl );
_tcscpy( pItemImpl->cDriveString,
reinterpret_cast<LPCTSTR>(strSysFilePath->buffer) );
- pItemImpl->cDriveString[0] = _toupper(
pItemImpl->cDriveString[0] );
+ pItemImpl->cDriveString[0] = toupper(
pItemImpl->cDriveString[0] );
if ( pItemImpl->cDriveString[_tcslen(pItemImpl->cDriveString)
- 1] != '\\' )
_tcscat( pItemImpl->cDriveString, TEXT( "\\" ) );
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
