Hi all, Noel makes a good point (my initial was totally wrong - not sure why I wrote what I wrote - kids screaming in the background, sorry).
I'm a bit curious about the deprecation warnings: LocalOfficeConnection is being derived from a deprecated class, but is not itself deprecated. I'm a but confused how this makes any sense? Does anyone know the reasoning here? I assumed that LocalOfficeConnection was deprecated also because of it, but for some reason wasn't being marked as such either :( Chris On Tue, Apr 16, 2013 at 8:14 PM, Noel Grandin (via Code Review) < ger...@gerrit.libreoffice.org> wrote: > Noel Grandin has posted comments on this change. > > Change subject: Deprecated warnings disabled for Office Beans. > ...................................................................... > > > Patch Set 1: This need some tweaks before it is merged > > Your commit message doesn't make sense - the classes using the deprecated > classes are not themselves marked as deprecated. > > If they were, the warnings would not be there. > > For example, if LocalOfficeConnection was marked @deprecated, then you > would not need the @SuppressWarnings. > > -- > To view, visit https://gerrit.libreoffice.org/3407 > To unsubscribe, visit https://gerrit.libreoffice.org/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: Ic49101f362dbff33afba63fb96b36ae88d3633f5 > Gerrit-PatchSet: 1 > Gerrit-Project: core > Gerrit-Branch: master > Gerrit-Owner: Chris Sherlock <chris.sherloc...@gmail.com> > Gerrit-Reviewer: Noel Grandin <noelgran...@gmail.com> >
_______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice