* Charles Wilson wrote on Thu, Apr 19, 2007 at 08:08:41PM CEST: > Ralf Wildenhues wrote: > > > >It's a good choice of testing, and should be done again with the final > >patch. Plus one test on Solaris with its /bin/sh. (Just noting this, > >I can probably do these tests then.) > > will do for linux & mingw, but have no unencumbered access to solaris at > present.
I'll do that then. > >>+ AS_IF([test "$os_major" -gt > >>"1"],[lt_cv_sys_argz_works=yes],dnl > >>+ [test "$os_minor" -gt > >>"5"],[lt_cv_sys_argz_works=yes],dnl > >>+ [test "$os_micro" -gt > >>"24"],[lt_cv_sys_argz_works=yes],dnl > > > >No need for double quoting the literal integers. And if it can happen > >that $os_micro is the empty string (which I'll consider quite likely), > >then double quoting isn't enough precaution against error output, as > >"" isn't interpreted by test as a number. > > Okay, but actually, all cygwin releases are guaranteed to have non-empty > major, minor, and micro numbers -- and we're inside a $host_os == cygwin > block, here. Oh, I overlooked this fact in my review. Ignore that comment then. Cheers, Ralf
