Ralf Wildenhues wrote:
>>> Other than that, the only thing this patch is missing is a testsuite
>>> test ensuring that "--" really is passed through. (Such an addition
>>> is preapproved.)
>> I tested this manually using -DDEBUGWRAPPER, but I don't know diddly
>> about writing tests for the testsuite -- and besides, this test
would be
>> mingw/cygwin-host specific, and would fail on all cross builds unless
>> $build has wine and binfmt... if the test is so fragile, what's the
>> point?
>
> I don't understand. Programs on systems != mingw, cygwin should pass
> "--" through as well. But inexperience with Autotest granted, I'll
> write a test.
I just meant that we don't use the cwrapper at all, unless
$host=mingw/cygwin. And when $host is mingw/cygwin, the cwrapper is
compiled using the $host compiler, so it won't run on $build unless
not-cross, or unless $build has a suitable emulation environment.
Of course, if $build != $host, and $build does not have a suitable
emulation environment, everything in the whole test suite will fail/skip
anyway, so that concern may not be an issue...
> Please go ahead with the patch, thanks!
OK.
--
Chuck
