On Sun, Nov 2, 2008 at 12:59 PM, Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > Hello Dan, > > * Dan Nicholson wrote on Sat, Nov 01, 2008 at 09:48:28PM CET: >> Add an option, --no-la-files, which skips installing the .la files. When >> used with --mode=uninstall, libtool tries to use the .lai file from the >> build directory. >> >> Signed-off-by: Dan Nicholson <[EMAIL PROTECTED]> >> --- >> Does this seem reasonable? I've checked that this doesn't break >> uninstall or distcheck. > > It does break third-party packages that would like to link against your > library. So we should not encourage it.
It doesn't break 3rd party packages when you're installing a system library. Would it make any difference if I reworked the patch to: 1) Only apply when the destination directory is a system libdir 2) Print a big warning that --no-la-files can break 3rd party packages >> + if ! $opt_no_la_files; then > > FWIW, 'if !' is not portable, 'if $opt; then :; else ...' would be. OK. >> + if $opt_no_la_files; then >> + file=.libs/"$name"i >> + test -f "$file" || file=`find . -type f -name "$name"i` > > Not safe when files with whitespace in the name are present. Because the `find` command substitution is not quoted? >> + test -n "$file" || file=.libs/"$name"i >> + func_dirname "$file" "" "." >> + dir="$func_dirname_result" -- Dan _______________________________________________ http://lists.gnu.org/mailman/listinfo/libtool
