Hi Reinhold, I think there's some scope for reducing code duplication in the engraver and parser-clef.scm.
Cheers, Neil http://codereview.appspot.com/2726043/diff/1/input/regression/cue-clef.ly File input/regression/cue-clef.ly (right): http://codereview.appspot.com/2726043/diff/1/input/regression/cue-clef.ly#newcode4 input/regression/cue-clef.ly:4: texidoc = "Clefs for cue notes: Normal clefs should be printed, and in addition indent this looks like several tests bundled together http://codereview.appspot.com/2726043/diff/1/input/regression/cue-clef.ly#newcode12 input/regression/cue-clef.ly:12: \clef "bass" indent http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc File lily/cue-clef-engraver.cc (right): http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc#newcode41 lily/cue-clef-engraver.cc:41: Direction octave_dir_; remove (appears to be left over in clef-engraver.cc from old ottava code) http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc#newcode47 lily/cue-clef-engraver.cc:47: // DECLARE_TRANSLATOR_LISTENER (cue_end_clef); remove? http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc#newcode74 lily/cue-clef-engraver.cc:74: octave_dir_ = CENTER; remove http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc#newcode100 lily/cue-clef-engraver.cc:100: Item *item = dynamic_cast<Item *> (info.grob ()); Item *item = info.item (); http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc#newcode121 lily/cue-clef-engraver.cc:121: Item *g = make_item ("OctavateEight", SCM_EOL); farm out to separate function? http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc#newcode198 lily/cue-clef-engraver.cc:198: if (scm_is_string (glyph)) { remove { } http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc#newcode200 lily/cue-clef-engraver.cc:200: } else { remove { } http://codereview.appspot.com/2726043/diff/1/lily/cue-clef-engraver.cc#newcode220 lily/cue-clef-engraver.cc:220: if (clef_ && octavate_) { newline for { http://codereview.appspot.com/2726043/diff/1/lily/pitch-scheme.cc File lily/pitch-scheme.cc (right): http://codereview.appspot.com/2726043/diff/1/lily/pitch-scheme.cc#newcode173 lily/pitch-scheme.cc:173: if (scm_is_number (cue_pos)) { remove { } http://codereview.appspot.com/2726043/diff/1/ly/music-functions-init.ly File ly/music-functions-init.ly (right): http://codereview.appspot.com/2726043/diff/1/ly/music-functions-init.ly#newcode250 ly/music-functions-init.ly:250: 'origin location)) don't need to set 'origin (it's done automatically by the syntax constructor `music-function') http://codereview.appspot.com/2726043/diff/1/scm/music-functions.scm File scm/music-functions.scm (right): http://codereview.appspot.com/2726043/diff/1/scm/music-functions.scm#newcode802 scm/music-functions.scm:802: (make-music 'Music) indent http://codereview.appspot.com/2726043/diff/1/scm/music-functions.scm#newcode806 scm/music-functions.scm:806: (context-spec-music (make-voice-props-revert) 'CueVoice "cue") remove extra space http://codereview.appspot.com/2726043/diff/1/scm/music-functions.scm#newcode808 scm/music-functions.scm:808: (make-music 'Music) indent http://codereview.appspot.com/2726043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel