On 2012/10/01 08:46:09, marc wrote:
Am 30.09.2012 22:03, schrieb d...@gnu.org:
> On 2012/09/30 19:44:49, marc wrote:
>> Am 30.09.2012 11:02, schrieb d...@gnu.org:
>> > [...]
>> > First, the define-public is asking for trouble. You are exposing
an
>> > internal Scheme data structure to users and make it overwritable
by
> the
>> > user. If the user follows this invitation, the effects will bleed
> over
>> > from session to session. Never do that.
>> Ok.
>
> No, it's not ok.  Hold your horses, this is another case too stupid
for
> documenting and walking people through.  Give me two days, and then
you
> replace your define-public for the alists with define-session, and
> that's it.  The rest of the code stays as it is.
That's good news! I think I owe you something, thanks in advance!

Or define-session-public.  define-session will be for data that is reset
per session, but not publicly accessible.  Which is probably what you
want if all the accessor functions are already in your .scm file.

http://codereview.appspot.com/6498052/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to