Am 14.10.2012 19:17, schrieb janek.lilyp...@gmail.com:
I dedicate all my code reviews to Graham Percival.
Marc,
your change is so big that i have trouble grasping it and understanding
everything, but i have a few specific comments.
Janek
http://codereview.appspot.com/6498052/diff/50001/Documentation/snippets/new/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly
File
Documentation/snippets/new/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly
(right):
http://codereview.appspot.com/6498052/diff/50001/Documentation/snippets/new/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly#newcode1
Documentation/snippets/new/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly:1:
\version "2.17.5"
I see this snippet both as new snippet in Documentation/snippets/new and
as modified snippet in Documentation/snippets. Is this correct?
The CG says so, otherwise it would be removed by the next makelsr call.
http://codereview.appspot.com/6498052/diff/50001/Documentation/snippets/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly
File
Documentation/snippets/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly
(right):
http://codereview.appspot.com/6498052/diff/50001/Documentation/snippets/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly#newcode20
Documentation/snippets/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly:20:
is this empty line intended?
You don't like it? ;-)
Sorry, will remove it before pushing to staging.
http://codereview.appspot.com/6498052/diff/50001/lily/volta-bracket.cc
File lily/volta-bracket.cc (right):
http://codereview.appspot.com/6498052/diff/50001/lily/volta-bracket.cc#newcode141
lily/volta-bracket.cc:141: ly_string2scm (str)));
I'm sorry (that's probably a noob question) - what |= is?
It's the same as a+= 2, just with a bitwise or.
http://codereview.appspot.com/6498052/diff/50001/python/convertrules.py
File python/convertrules.py (right):
http://codereview.appspot.com/6498052/diff/50001/python/convertrules.py#newcode3394
python/convertrules.py:3394:
is this blank line intentional?
See above.
http://codereview.appspot.com/6498052/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
