On 2017/01/07 17:12:57, david.nalesnik wrote:
Please review. Thanks!
Hi David, very nice. I can't review C++-code, but applied the patch and tested with: \layout { \override Hairpin.layer = 200 \override Hairpin.color = #red } { \override Hairpin.minimum-length = 40 \override Hairpin.shorten-pair = #'(-4 . -4) c'1\pppp~\< c'1~ c'2~ c'2\ffff\! \break c'1~\< c'1~ c'2~ c'2\! } Observations: (1) Obviously the actual printed extents of the Hairpin are affected. (2) It's now possible that the Hairpin collides with DynamicText for bad settings of shorten-pair. DynamicText is not pushed out of the way. So shorten-pair is _not_ the correct tool to set the overall length of a Hairpin, but for fine tunings. For that purpose minimum-length is still the way to go. This should be documented. Worth a regtest and an entry in changes. https://codereview.appspot.com/315350043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel