Sorry to come back to this that late. I can't comment on the C++ part of it. Some other remarks, though:
https://codereview.appspot.com/353850043/diff/60001/input/regression/multi-measure-rest-number-threshold.ly File input/regression/multi-measure-rest-number-threshold.ly (right): https://codereview.appspot.com/353850043/diff/60001/input/regression/multi-measure-rest-number-threshold.ly#newcode14 input/regression/multi-measure-rest-number-threshold.ly:14: \set restNumberThreshold = 0 Iiuc, this tests whether \unset works but not whether "only future multi measure rests" are affected. To do so some code default-code should be done first, imho. Probably: { \compressFullBarRests R1*2 R1 \set restNumberThreshold = 0 R1*2 R1 \unset restNumberThreshold R1*2 R1 } https://codereview.appspot.com/353850043/diff/60001/ly/engraver-init.ly File ly/engraver-init.ly (right): https://codereview.appspot.com/353850043/diff/60001/ly/engraver-init.ly#newcode272 ly/engraver-init.ly:272: restNumberThreshold = 1 Inserting the deafult here in Voice, is not sufficient, see: { \applyContext #(lambda (ctx) (write (ly:context-property ctx 'restNumberThreshold))) R1 } displaying '() I'd do it in Score. Settings for Chords and Tabs are done in Score as well, probably for the same reason. https://codereview.appspot.com/353850043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
