The callback should be able to handle resource descriptors that it doesn't know about, new ones can be added at any time.
This change was made during the resource manager update. I think that I would like to have WalkResources return the EndTag to the callback since it is a valid resource descriptor and it does impart information to the callback. Bob > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:linux-acpi- > [EMAIL PROTECTED] On Behalf Of Len Brown > Sent: Thursday, January 05, 2006 12:13 AM > To: [EMAIL PROTECTED]; linux-acpi@vger.kernel.org > Subject: [PATCH] [ACPI] fix pnpacpi regression resulting from ACPICA > 20051117 > > Andrew, > I just pushed this patch to the test branch of the acpi git tree. > Please pull my tree again or apply this patch before you ship > the next -mm if possible. > > Thanks to Shaohua Li for keeping me awake helping me to fix this:-) > > thanks, > -Len > > In ACPICA 20051117, acpi_walk_resources() started > sending ACPI_RESOURCE_TYPE_END_TAG to the callback > routine which wasn't prepared for it, causing > _CRS to fail and PnPACPI to not recognize any devices: > > pnp: ACPI device : hid PNP0C02 > pnp: PnPACPI: unknown resource type 7 > pnp: PnPACPI: METHOD_NAME__CRS failure for PNP0c02 > > Signed-off-by: Len Brown <[EMAIL PROTECTED]> > > --- > > drivers/acpi/resources/rsxface.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > ed349a8a0a780ed27e2a765f16cee54d9b63bfee > diff --git a/drivers/acpi/resources/rsxface.c > b/drivers/acpi/resources/rsxface.c > index 50a956b..5408e5d 100644 > --- a/drivers/acpi/resources/rsxface.c > +++ b/drivers/acpi/resources/rsxface.c > @@ -286,6 +286,12 @@ acpi_walk_resources(acpi_handle device_h > break; > } > > + /* end_tag indicates end-of-list */ > + > + if (resource->type == ACPI_RESOURCE_TYPE_END_TAG) { > + break; > + } > + > /* Invoke the user function, abort on any error returned */ > > status = user_function(resource, context); > @@ -298,12 +304,6 @@ acpi_walk_resources(acpi_handle device_h > break; > } > > - /* end_tag indicates end-of-list */ > - > - if (resource->type == ACPI_RESOURCE_TYPE_END_TAG) { > - break; > - } > - > /* Get the next resource descriptor */ > > resource = > -- > 1.0.6-g58e3 > - > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
