On Wednesday, 29 September, 2010, Josef Bacik wrote:
> On Wed, Sep 29, 2010 at 12:48:15AM +0200, Goffredo Baroncelli wrote:
> > Hi Josef,
> > 
> > please, if you add or change a command pay attention to update the man 
page 
> > too (man/btrfs.8.in).
> >
> 
> Hrm I missed that with git add, I'll fix that up.
[...]
> > > +
> > > + ret = ioctl(fd, BTRFS_IOC_DISK_INFO, args);
> > > + if (ret) {
> > > +         printf("failed ioctl\n");
> > Please use
> >             fprintf(stderr,"ERROR: failed ioctl\n");
> >
> 
> Ugh oops sorry, forgot to get rid of my debug printing, I'll kill that.
If you use this command on a non btrfs filesystem, this is the first point of 
failure. So please don't kill it.




-- 
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <[email protected]>
Key fingerprint = 4769 7E51 5293 D36C 814E  C054 BF04 F161 3DC5 0512
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to