On 7/24/14, 4:25 PM, Chris Mason wrote:
> On 06/25/2014 07:55 PM, Eric Sandeen wrote:
>> First off: total RFC, don't merge this; it builds, but
>> is totally untested.
>>
>> open_ctree() is almost 1000 lines long. I've started trying
>> to refactor it, primarily into helper functions, and also
>> simplifying (?) things a bit at the beginning by removing the
>> ret = func(); if (ret) { err = ret; goto ... } dance where it's not
>> needed.
>>
>> Does this look like a reasonable thing to do? Have I cut
>> things into the right chunks? Would you rather see it as
>> as series of patches, moving one hunk of code at a time?
>
> I do love this patch, either as a series or one big patch. Whatever
> makes it easiest for you to test is fine with me.
Oh right! I remember this thing! Let me try to get back to it... ;)
Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
