On Mon, Sep 25, 2017 at 10:42:06AM +0300, Marat Khalili wrote: > On 25/09/17 10:30, Nikolay Borisov wrote: > >On 19.09.2017 10:41, Misono, Tomohiro wrote: > >>"btrfs subvolume create/delete" outputs the message of "Create/Delete > >>subvolume ..." even when an operation fails. > >>Since it is confusing, let's outputs the message only when an operation > >>succeeds. > >Please change the verb to past tense, more strongly signaling success - > >i.e. "Created subvolume" > What about recalling some UNIX standards and returning to NOT > outputting any message when operation succeeds? My scripts are full > of grep -v calls after each btrfs command, and this sucks (and I > don't think I'm alone in this situation). If you change the message > a lot of scripts will have to be changed, at least make it worth it.
Seconded. Make sure the return code reflects the result, and drop the printed message (or keep it if there's a --verbose flag, maybe). Hugo. -- Hugo Mills | If you see something, say nothing and drink to hugo@... carfax.org.uk | forget http://carfax.org.uk/ | PGP: E2AB1DE4 | Welcome to Night Vale
signature.asc
Description: Digital signature
