On Fri, 30 Jul 2010 17:57:22 +0530
Suresh Jayaraman <sjayara...@novell.com> wrote:

> From: Suresh Jayaraman <sjayara...@suse.de>
> Subject: [PATCH 1/2] cifs: show features compiled in as part of DebugData
> 
> This patch adds the features that are compiled in to the CIFS debugging data
> as shown below:
> 
>       $cat /proc/fs/cifs/DebugData 
>       Display Internal CIFS Data Structures for Debugging
>       ---------------------------------------------------
>       CIFS Version 1.64
>       Features: dfs fscache posix spnego xattr 
>       Active VFS Requests: 0
>       ...
> 
> This patch provides a definitive way to tell what features are currently
> enabled in the running kernel. This could also help debugging.
> 
> Signed-off-by: Suresh Jayaraman <sjayara...@suse.de>
> Cc: Jeff Layton <jlay...@redhat.com>
> ---
>  fs/cifs/cifs_debug.c |   26 ++++++++++++++++++++++++++
>  1 files changed, 26 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/cifs_debug.c
> index 4fce6e6..fdb2db5 100644
> --- a/fs/cifs/cifs_debug.c
> +++ b/fs/cifs/cifs_debug.c
> @@ -119,6 +119,32 @@ static int cifs_debug_data_proc_show(struct seq_file *m, 
> void *v)
>                   "Display Internal CIFS Data Structures for Debugging\n"
>                   "---------------------------------------------------\n");
>       seq_printf(m, "CIFS Version %s\n", CIFS_VERSION);
> +     seq_printf(m, "Features: ");
> +#ifdef CONFIG_CIFS_DFS_UPCALL
> +     seq_printf(m, "dfs");
> +     seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_FSCACHE
> +     seq_printf(m, "fscache");
> +     seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_WEAK_PW_HASH
> +     seq_printf(m, "lanman");
> +     seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_POSIX
> +     seq_printf(m, "posix");
> +     seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_UPCALL
> +     seq_printf(m, "spnego");
> +     seq_putc(m, ' ');
> +#endif
> +#ifdef CONFIG_CIFS_XATTR
> +     seq_printf(m, "xattr");
> +     seq_putc(m, ' ');
        ^^^^^^
        Nit -- this space isn't needed.
> +#endif
> +     seq_putc(m, '\n');
>       seq_printf(m, "Active VFS Requests: %d\n", GlobalTotalActiveXid);
>       seq_printf(m, "Servers:");
>  
> 
> 

Other than that, looks good.
-- 
Jeff Layton <jlay...@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to