* Sergey Mironov | 2009-11-10 17:00:31 [+0300]:
> 116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key,
> 117 unsigned int len)
> 118 {
>...
>
>/** BUG? Should it be 'op->fallback.cip' instead of 'op->fallback.blk' ? **/
>
> 138 op->fallback.blk->base.crt_flags &= ~CRYPTO_TFM_REQ_MASK;
> 139 op->fallback.blk->base.crt_flags |= (tfm->crt_flags &
>CRYPTO_TFM_REQ_MASK);
>
>...
>
> 144 tfm->crt_flags |=
>(op->fallback.blk->base.crt_flags & CRYPTO_TFM_RES_MASK);
> 145 }
> 146 return ret;
Yup, good catch. It has to be cip instead of blk. I've copy/pasted it
and the same bug is in s390's crypto driver. No one noticed it because
both structs are equal, just the name / type is different.
Do you mind sending a patch?
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
