-----Original Message----- From: Michael Ellerman [mailto:m...@ellerman.id.au] Sent: Friday, April 07, 2017 4:22 PM To: Laurentiu Tudor <laurentiu.tu...@nxp.com>; Horia Geantă <horia.gea...@nxp.com>; Herbert Xu <herb...@gondor.apana.org.au>; Scott Wood <o...@buserror.net>; Roy Pledge <roy.ple...@nxp.com> Cc: Claudiu Manoil <claudiu.man...@nxp.com>; Cristian Stoica <cristian.sto...@nxp.com>; Dan Douglass <dan.dougl...@nxp.com>; linux-arm-ker...@lists.infradead.org; Vakul Garg <vakul.g...@nxp.com>; linuxppc-...@lists.ozlabs.org; David S. Miller <da...@davemloft.net>; Alexandru Porosanu <alexandru.poros...@nxp.com>; linux-crypto@vger.kernel.org Subject: Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Importance: High
Laurentiu Tudor <laurentiu.tu...@nxp.com> writes: > On 04/05/2017 01:06 PM, Michael Ellerman wrote: >> Laurentiu Tudor <laurentiu.tu...@nxp.com> writes: >> >>> Hi Michael, >>> >>> Just a couple of basic things to check: >>> - was the dtb updated to the newest? >> >> Possibly not, it's an automated build/boot, I'll have to check what >> it does with the dtb. >> >>> - is the qman node present? This should be easily visible in >>> /proc/device-tree/soc@ffe000000/qman@318000. >> >> No it's not there. >> >> That's running linux-next with: >> >> CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=n >> >> >> Does that mean I didn't update the device tree? > > I think so. Also, I just checked that the node is actually there by > compiling p5020ds.dts and then decompiling the dtb. > OK, I'll make sure I update the DTB. > > It will still be good if the code was a bit more robust about the qman being > missing. Totally agree. We should handle this error condition. --- Thanks & Best Regards, Laurentiu
