On Fri, Apr 21, 2017 at 01:36:45PM +0200, Corentin Labbe wrote:
> > > > + memset(ipad + keylen, 0, blocksize - keylen);
> > > > + memcpy(opad, ipad, blocksize);
> > > > +
> > > > + for (i = 0; i < blocksize; i++) {
> > > > + ipad[i] ^= 0x36;
> > > > + opad[i] ^= 0x5c;
> > >
> > > What are these constant ?
> >
> > They are defined in the HMAC RFC, as ipad and opad values. See
> > https://www.ietf.org/rfc/rfc2104.txt.
> >
>
> Since many driver use them, I think defining them in include/ should be done
> (HMAC_IPAD/HMAC_OPAD)
> I will send a patch for it.OK, I'll send a following up patch on this driver when your series is merged. Antoine -- Antoine Ténart, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
