Am Freitag, 21. April 2017, 17:42:10 CEST schrieb abed mohammad kamaluddin:
Hi abed, > Hi Stephan, > > On Tue, Apr 18, 2017 at 3:42 PM, Stephan Müller <smuel...@chronox.de> wrote: > > Am Donnerstag, 13. April 2017, 20:34:54 CEST schrieb Abed Kamaluddin: > > > > May I propose that you look into the patches for skcipher and aead > > regarding memory handling updates that are currently discussed. There you > > will find the sendmsg code with two parts: > > > > 1. checking of the input data of cmsg and setting the ctx respectively. > > > > 2. the big while loop for getting all user space data > > > > I guess you have seen that I would like to consolidate the algif > > implementations once the memory handling patch is in and agreed on. My > > plan > > is: Bullet 1 will be private to the algif implementation, so leave your > > code. Bullet 2 will be moved into a common service function. Thus, may I > > propose that you simply copy the entire while loop with the same TX data > > structures into your sendmsg code. This way you do not have the mentioned > > limit. > > > > Also, simply copy the sendpage code from the patch set to support splice/ > > vmsplice. > > Thanks for the suggestions and helpful pointers, I will rework the > patch and incorporate these, hoping that the compression interface > will be exported. These changes would also remain unaffected by any > changes to the acomp interface. Just diff the just RFCed algif_kpp with the proposed patch set for algif_skcipher and algif_aead. There you will see that 80% of all code is identical (if you disregard the different namespace). And that is the code I am referring to. > > Thanks > Abed (Cavium) > Regards, Ciao Stephan
