'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
necessary to do it here, so remove it.

It should return error immediately when return value of 'hpre_cfg_by_dsm'
is non-zero, and no need to execute the remaining sentences.

Signed-off-by: Hui Tang <tanghu...@huawei.com>

---
v1 -> v2:
   - Return immediately when return value of 'hpre_cfg_by_dsm' is
     non-zero.
v2 -> v3:
   - Add description for return if function fails.
---
 drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c 
b/drivers/crypto/hisilicon/hpre/hpre_main.c
index a8c7921..264684a 100644
--- a/drivers/crypto/hisilicon/hpre/hpre_main.c
+++ b/drivers/crypto/hisilicon/hpre/hpre_main.c
@@ -384,7 +384,7 @@ static int hpre_set_user_domain_and_cache(struct hisi_qm 
*qm)
        if (qm->ver == QM_HW_V2) {
                ret = hpre_cfg_by_dsm(qm);
                if (ret)
-                       dev_err(dev, "acpi_evaluate_dsm err.\n");
+                       return ret;
 
                disable_flr_of_bme(qm);
        }
-- 
2.8.1

Reply via email to