On 2010-12-15 20:31, Lars Ellenberg wrote:
> I fail to see the usefulnes.
>
> The only additional thing over an opencoded kill (which is one line)
> is the check for zombie status. So what. It buys nothing.
> We don't have a zombie problem. I've not seen zombies for a long time,
> unless I deliverately provoke them.
> Daemons (here by defined as anything that reparents to init) will never
> become zombie (unless init is dead, but then this code would have
> difficulties to run as well).
> Some daemons may have neglected children that go zombie...
> but you won't detect those, you don't know their pid.
> Once the parent dies, they are reaped anyways.
>
> Writing pid files (or remebering a pid in any other way) for non-daemons
> is useless, and should never be done by a resource agent.
>
> And to really check that the process runs and _works_ as expected, you
> need to do a real check anyways ("select now()", "wget | grep" ...).
>
> So what I try to say is, for the single resource agent,
> it does not make any difference at all whether it says
>
> if ocf_is_pid_running $pid ; then do_real_monitor; fi
> or
> if kill -0 $pid ; then do_real_monitor; fi
>
> and I like the latter better.Fair enough. If I've been trying to fix something that ain't broken, let's drop the patch. It would have been helpful, though, if you had screamed when I documented exactly this approach (minus the convenience function, obviously) in the RA dev guide. Anyway, let's drop this patch and I'll wipe that section from the dev guide. Florian
signature.asc
Description: OpenPGP digital signature
_______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
