On Wed, Jan 19, 2011 at 01:49:03AM +0100, Lars Ellenberg wrote:
> On Tue, Jan 18, 2011 at 12:15:03PM +0100, Dejan Muhamedagic wrote:
> > On Fri, Jan 14, 2011 at 06:07:44PM +0100, Alexander Krauth wrote:
> > > # HG changeset patch
> > > # User Alexander Krauth <[email protected]>
> > > # Date 1295024363 -3600
> > > # Node ID 7b76bfaf99e1791c9464aa53520ef20fce0a2356
> > > # Parent 267ac174f72d7bfa9b98f573f2a8326ca53df0c2
> > > Low: SAPInstance: remove unnecessary usage of eval to start processes
> > >
> > > diff -r 267ac174f72d -r 7b76bfaf99e1 heartbeat/SAPInstance
> > > --- a/heartbeat/SAPInstance Fri Jan 14 09:41:01 2011 +0100
> > > +++ b/heartbeat/SAPInstance Fri Jan 14 17:59:23 2011 +0100
> > > @@ -448,7 +448,7 @@
> > > if have_binary "$VALUE"
> > > then
> > > ocf_log info "Calling userexit ${NAME} with customer script file
> > > ${VALUE}"
> > > - eval "$VALUE" >/dev/null 2>&1
> > > + $VALUE >/dev/null 2>&1
>
> No.
>
> Again you are executing something different than you checked for.
>
> if you do have_binary "$VALUE",
> you likely want to do "$VALUE", not $VALUE.
There should be no difference in this case, right?
> > > ocf_log info "Exiting userexit ${NAME} with customer script file
> > > ${VALUE}, returncode: $?"
> > > else
> > > ocf_log warn "Attribute ${NAME} is set to ${VALUE}, but this file
> > > is not executable"
> > > _______________________________________________________
> > > Linux-HA-Dev: [email protected]
> > > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > > Home Page: http://linux-ha.org/
> >
> > Applied. Cheers, Dejan
> > _______________________________________________________
> > Linux-HA-Dev: [email protected]
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
>
> --
> : Lars Ellenberg
> : LINBIT | Your Way to High Availability
> : DRBD/HA support and consulting http://www.linbit.com
>
> DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.
> _______________________________________________________
> Linux-HA-Dev: [email protected]
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
