On Fri, Feb 22, 2008 at 02:10:20PM +0900, Isaku Yamahata wrote: ... > --- /dev/null > +++ b/include/asm-ia64/sync_bitops.h > @@ -0,0 +1,61 @@ > +#ifndef __XEN_SYNC_BITOPS_H__ > +#define __XEN_SYNC_BITOPS_H__
Typically, these #defines are made to match the filename. ... > +#define ADDR (*(volatile long *) addr) This seems like a leftover #define. Additionally, ADDR seems a bit vague and easily misused. Since I don't see it used anywhere else in that patch, I will assume it should be tossed, but reserve the right to rescind this comment later. ... > +#endif /* __XEN_SYNC_BITOPS_H__ */ Same as the first. Thanks, Robin - To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
