Hi Jeff, hi all,
here's a preliminary patch that converts the libata debugging code to
something similar to the netdev debugging mechanism. This is, however, only
an alpha version and introduces the main concept as proposed by Jeff. Its
purpose is to collect as much feedback from you all as possible in order for
me to correct it and Do the Right Thing(tm). (That's why I converted only
libata-core.c - the rest after the review.) Some questions that arose during
the process:
1. ata_dev_classify() doesn't have an ata_port pointer defined in order to
query the debugging level but its users have so should i convert it to
unsigned int ata_dev_classify(struct ata_taskfile *tf, struct ata_port *ap)
so that the ata_port pointer gets passed and debugging is enabled?
2. ata_{host,device}_add() and ata_pci_init_one() are initialization functions
and in this case an ata_port is not yet/still getting initialized. How should
we print debugging messages there?
3. What about the assert() macro in <include/linux/libata.h>?
Thanks and regards,
Borislav Petkov.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
