>> +static inline void writelfl(unsigned long data, void __iomem *addr)
>> +{
>> + writel(data, addr);
>> + (void) readl(addr); /* flush */
>
> no need for the (void) case.
Not strictly necessary, but a redundant (void) cast is a pretty standard
way of documenting "yes, I really mean to ignore the return value."
I'd like to suggest that it's helpful to the reader and should stay.
(Maybe even, for those who don't know, change the comment to
"Standard PCI flush trick.")
On your other style comments, I agree.
Well, except that "braces" are {}, while () are "parentheses" or "parens".
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
