Re: [PATCH 0/2] libata: ata_pio_task() accessing 'ap->pio_task_state' fix

[Jeff Garzik]

Albert Lee wrote:

Only one minor addition for your review:

* ata_pio_block() changed to go to PIO_ST_LAST state, instead of
  going to PIO_ST_IDLE state directly and calling ata_poll_qc_complete().

i.e.
@@ -2845,9 +2852,7 @@
    if (is_atapi_taskfile(&qc->tf)) {
        /* no more data to transfer or unsupported ATAPI command */
        if ((status & ATA_DRQ) == 0) {
-            ap->pio_task_state = PIO_ST_IDLE;
-
-            ata_poll_qc_complete(qc, status);
+            ap->pio_task_state = PIO_ST_LAST;
            return;
        }

hmmmm.  I think that should be PIO_ST_ERR not PIO_ST_LAST.  Comments?

        Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html