On Wednesday 03 January 2007 01:01, Mark Lord wrote:
>..
> This patch isn't really needed, but it might provide an "out"
> just in case somebody has some really non-compliant hardware
> out there someday.
>
> Add a boot/module parameter for libata to force the ATA_16
> SCSI opcode to not be interpreted as a standards-compliant
> ATA passthrough mechanism when used on an ATAPI device
> -- instead, it gets passed directly to the ATAPI device.
This version of the patch leaves ATA_16 enabled for non-ATAPI
regardless of the setting of the new module parm. Take your pick.
Signed-off-by: Mark Lord <[EMAIL PROTECTED]>
--- old/drivers/ata/libata.h 2007-01-02 19:06:56.000000000 -0500
+++ linux/drivers/ata/libata.h 2007-01-03 00:55:01.000000000 -0500
@@ -46,6 +46,7 @@
extern struct workqueue_struct *ata_aux_wq;
extern int atapi_enabled;
+extern int atapi_passthru;
extern int atapi_dmadir;
extern int libata_fua;
extern struct ata_queued_cmd *ata_qc_new_init(struct ata_device *dev);
--- old/drivers/ata/libata-core.c 2007-01-02 19:09:06.000000000 -0500
+++ linux/drivers/ata/libata-core.c 2007-01-03 00:52:51.000000000 -0500
@@ -78,6 +78,10 @@
module_param(atapi_enabled, int, 0444);
MODULE_PARM_DESC(atapi_enabled, "Enable discovery of ATAPI devices (0=off,
1=on)");
+int atapi_passthru = 0;
+module_param(atapi_passthru, int, 0444);
+MODULE_PARM_DESC(atapi_passthru, "Enable passthru of SCSI opcode 0x85 to ATAPI
devices");
+
int atapi_dmadir = 0;
module_param(atapi_dmadir, int, 0444);
MODULE_PARM_DESC(atapi_dmadir, "Enable ATAPI DMADIR bridge support (0=off,
1=on)");
--- old/drivers/ata/libata-scsi.c 2007-01-02 19:20:49.000000000 -0500
+++ linux/drivers/ata/libata-scsi.c 2007-01-03 01:21:28.000000000 -0500
@@ -2650,7 +2650,7 @@
static inline ata_xlat_func_t ata_get_xlat_func(struct ata_device *dev, u8 cmd)
{
- if (cmd == ATA_16)
+ if (cmd == ATA_16 && !atapi_passthru)
return ata_scsi_pass_thru;
if (dev->class == ATA_DEV_ATAPI)
@@ -2676,6 +2676,7 @@
return ata_scsi_verify_xlat;
case ATA_12:
+ case ATA_16:
return ata_scsi_pass_thru;
case START_STOP:
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
