Eric D. Mudama wrote:
Per Jeff's suggestion, this patch rearranges the info printed for ATA
drives into dmesg to add the full ATA firmware revision and model
information, while keeping the output to 2 lines.
Signed-off-by: Eric D. Mudama <[EMAIL PROTECTED]>
---
This extra information is helpful for debugging drive-related issues
on ATA drives connected with libata, especially when the user can't
easily run hdparm.
Update: added Tejun's formatting requests, and created the constants
necessary.
Diff is against 2.6.20-rc6 (roughly). Here's a snippet of my new
dmesg with this patch, showing the full and truncated firmware
revision information:
Looks pretty good to me at first glance. I'll review it again tonight
or tomorrow, when I make the next "apply SATA patches" pass.
FWIW, since this is not a bug fix, it will be going into 2.6.21 rather
than 2.6.20. As such, it will be applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
branch 'upstream' rather than branch 'upstream-fixes'.
Or, in shorthand, libata-dev.git#upstream.
Cheers and thanks,
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
