Hello.

Alan Cox wrote:
                .bootable       = ON_BOARD,             \
                .enablebits     = { {0x40, 1, 1}, {0x40, 0x10, 0x10} }, \
+               .pio_mask       = ATA_PIO5,             \
        }

Just noticed that this driver does nothing in its tuneproc() method. So, this mask is unrealistic. The method needs to be dropped for now along with config-jmicron_chipset_for_pio()

It doesn't need to do anything.

Not true. It should call ide_config_drive_speed() at least, else PIO autotuning won't actually work.

MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to