Hi Bart.
On Thu, Feb 14, 2008 at 09:55:50PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Add CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS to drivers/ide/Kconfig and use
> it instead of defining IDE_ARCH_OBSOLETE_DEFAULTS in <arch/ide.h>.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
> ---
> drivers/ide/Kconfig | 3 +++
> drivers/ide/ide.c | 5 +++++
> include/asm-alpha/ide.h | 3 ---
> include/asm-ia64/ide.h | 2 --
> include/asm-m32r/ide.h | 2 --
> include/asm-mips/mach-generic/ide.h | 2 --
> include/asm-powerpc/ide.h | 2 --
> include/asm-x86/ide.h | 2 --
> include/linux/ide.h | 7 -------
> 9 files changed, 8 insertions(+), 20 deletions(-)
>
> Index: b/drivers/ide/Kconfig
> ===================================================================
> --- a/drivers/ide/Kconfig
> +++ b/drivers/ide/Kconfig
> @@ -1099,6 +1099,9 @@ config BLK_DEV_IDEDMA
> config IDE_ARCH_OBSOLETE_INIT
> def_bool ALPHA || (ARM && !ARCH_L7200) || BLACKFIN || X86 || IA64 ||
> M32R || MIPS || PARISC || PPC || (SUPERH64 && BLK_DEV_IDEPCI) || SPARC
>
> +config IDE_ARCH_OBSOLETE_DEFAULTS
> + def_bool ALPHA || X86 || IA64 || M32R || MIPS || PPC32
> +
> endif
This time it is maybe borderline as it makes sense to see a list of
archs that uses this.
But still I would prefer you did like this:
drivers/ide/Kconfig:
config HAVE_IDE_ARCH_OBSOLETE_DEFAULTS
bool
config IDE_ARCH_OBSOLETE_DEFAULTS
depends on HAVE_IDE_ARCH_OBSOLETE_DEFAULTS
And then in each arch Kconfig include:
arch/alpha/Kconfig:
config ALPHA
select HAVE_ARCH_OBSOLETE_DEFAULTS
And the same for the others.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
