Thank you for review, Rob. On 06/23/2017 11:41 PM, Rob Herring wrote: > On Mon, Jun 19, 2017 at 05:48:21PM +0300, Todor Tomov wrote: >> Add DT binding document for Qualcomm Camera subsystem driver. > > "dt-bindings: media: ..." for the subject please.
I'll change it in the next version. > >> >> CC: Rob Herring <robh...@kernel.org> >> CC: devicet...@vger.kernel.org >> Signed-off-by: Todor Tomov <todor.to...@linaro.org> >> --- >> .../devicetree/bindings/media/qcom,camss.txt | 196 >> +++++++++++++++++++++ >> 1 file changed, 196 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/qcom,camss.txt >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,camss.txt >> b/Documentation/devicetree/bindings/media/qcom,camss.txt >> new file mode 100644 >> index 0000000..5213b03 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/qcom,camss.txt >> @@ -0,0 +1,196 @@ >> +Qualcomm Camera Subsystem >> + >> +* Properties >> + >> +- compatible: >> + Usage: required >> + Value type: <stringlist> >> + Definition: Should contain: >> + - "qcom,msm8916-camss" > > Okay if it is one node, but I'd like to see some agreement from other QC > folks that 1 node is appropriate. Ok. > >> +- reg: >> + Usage: required >> + Value type: <prop-encoded-array> >> + Definition: Register ranges as listed in the reg-names property. >> +- reg-names: >> + Usage: required >> + Value type: <stringlist> >> + Definition: Should contain the following entries: >> + - "csiphy0" >> + - "csiphy0_clk_mux" >> + - "csiphy1" >> + - "csiphy1_clk_mux" >> + - "csid0" >> + - "csid1" >> + - "ispif" >> + - "csi_clk_mux" >> + - "vfe0" >> +- interrupts: >> + Usage: required >> + Value type: <prop-encoded-array> >> + Definition: Interrupts as listed in the interrupt-names property. >> +- interrupt-names: >> + Usage: required >> + Value type: <stringlist> >> + Definition: Should contain the following entries: >> + - "csiphy0" >> + - "csiphy1" >> + - "csid0" >> + - "csid1" >> + - "ispif" >> + - "vfe0" >> +- power-domains: >> + Usage: required >> + Value type: <prop-encoded-array> >> + Definition: A phandle and power domain specifier pairs to the >> + power domain which is responsible for collapsing >> + and restoring power to the peripheral. >> +- clocks: >> + Usage: required >> + Value type: <prop-encoded-array> >> + Definition: A list of phandle and clock specifier pairs as listed >> + in clock-names property. >> +- clock-names: >> + Usage: required >> + Value type: <stringlist> >> + Definition: Should contain the following entries: >> + - "camss_top_ahb_clk" >> + - "ispif_ahb_clk" >> + - "csiphy0_timer_clk" >> + - "csiphy1_timer_clk" >> + - "csi0_ahb_clk" >> + - "csi0_clk" >> + - "csi0_phy_clk" >> + - "csi0_pix_clk" >> + - "csi0_rdi_clk" >> + - "csi1_ahb_clk" >> + - "csi1_clk" >> + - "csi1_phy_clk" >> + - "csi1_pix_clk" >> + - "csi1_rdi_clk" >> + - "camss_ahb_clk" >> + - "camss_vfe_vfe_clk" >> + - "camss_csi_vfe_clk" >> + - "iface_clk" >> + - "bus_clk" > > "_clk" is redundant. Yes, it will be better without it. -- Best regards, Todor Tomov
