Hi Bingbu, I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.19-rc4 next-20180921] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/bingbu-cao-intel-com/media-add-imx319-camera-sensor-driver/20180922-115504 base: git://linuxtv.org/media_tree.git master config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=openrisc All errors (new ones prefixed by >>): drivers/media//i2c/imx319.c: In function 'imx319_set_stream': >> drivers/media//i2c/imx319.c:2153:2: error: implicit declaration of function >> '__v4l2_ctrl_grab' [-Werror=implicit-function-declaration] __v4l2_ctrl_grab(imx319->vflip, enable); ^~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/__v4l2_ctrl_grab +2153 drivers/media//i2c/imx319.c 2118 2119 static int imx319_set_stream(struct v4l2_subdev *sd, int enable) 2120 { 2121 struct imx319 *imx319 = to_imx319(sd); 2122 struct i2c_client *client = v4l2_get_subdevdata(sd); 2123 int ret = 0; 2124 2125 mutex_lock(&imx319->mutex); 2126 if (imx319->streaming == enable) { 2127 mutex_unlock(&imx319->mutex); 2128 return 0; 2129 } 2130 2131 if (enable) { 2132 ret = pm_runtime_get_sync(&client->dev); 2133 if (ret < 0) { 2134 pm_runtime_put_noidle(&client->dev); 2135 goto err_unlock; 2136 } 2137 2138 /* 2139 * Apply default & customized values 2140 * and then start streaming. 2141 */ 2142 ret = imx319_start_streaming(imx319); 2143 if (ret) 2144 goto err_rpm_put; 2145 } else { 2146 imx319_stop_streaming(imx319); 2147 pm_runtime_put(&client->dev); 2148 } 2149 2150 imx319->streaming = enable; 2151 2152 /* vflip and hflip cannot change during streaming */ > 2153 __v4l2_ctrl_grab(imx319->vflip, enable); 2154 __v4l2_ctrl_grab(imx319->hflip, enable); 2155 2156 mutex_unlock(&imx319->mutex); 2157 2158 return ret; 2159 2160 err_rpm_put: 2161 pm_runtime_put(&client->dev); 2162 err_unlock: 2163 mutex_unlock(&imx319->mutex); 2164 2165 return ret; 2166 } 2167 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
