In the ov5640_try_frame_interval function, the ret variable actually holds
the frame rate index to use, which is represented by the enum
ov5640_frame_rate in the driver.

Make it more obvious.

Signed-off-by: Maxime Ripard <maxime.rip...@bootlin.com>
---
 drivers/media/i2c/ov5640.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 84c0aae74420..d7a1e1928baf 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -1975,8 +1975,8 @@ static int ov5640_try_frame_interval(struct ov5640_dev 
*sensor,
                                     u32 width, u32 height)
 {
        const struct ov5640_mode_info *mode;
+       enum ov5640_frame_rate rate = OV5640_30_FPS;
        u32 minfps, maxfps, fps;
-       int ret;
 
        minfps = ov5640_framerates[OV5640_15_FPS];
        maxfps = ov5640_framerates[OV5640_30_FPS];
@@ -1999,10 +1999,10 @@ static int ov5640_try_frame_interval(struct ov5640_dev 
*sensor,
        else
                fi->denominator = minfps;
 
-       ret = (fi->denominator == minfps) ? OV5640_15_FPS : OV5640_30_FPS;
+       rate = (fi->denominator == minfps) ? OV5640_15_FPS : OV5640_30_FPS;
 
-       mode = ov5640_find_mode(sensor, ret, width, height, false);
-       return mode ? ret : -EINVAL;
+       mode = ov5640_find_mode(sensor, rate, width, height, false);
+       return mode ? rate : -EINVAL;
 }
 
 static int ov5640_get_fmt(struct v4l2_subdev *sd,
-- 
2.19.1

Reply via email to