Hi Guennadi,
On Tue, Jul 31, 2012 at 05:14:25PM +0200, Guennadi Liakhovetski wrote:
> Hi Javier
>
> > @@ -436,7 +436,8 @@ static void mx2_camera_deactivate(struct mx2_camera_dev
> > *pcdev)
> > {
> > unsigned long flags;
> >
> > - clk_disable(pcdev->clk_csi);
> > + if (cpu_is_mx27())
> > + clk_disable_unprepare(pcdev->clk_csi);
>
> This tells me, there are already 2 things going on here:
>
> 1. add clock-(un)prepare operations to enable / disable. Is this a problem
> atm? is the driver non-functional without this change or is it just an API
> correctness change? I thought you replied to this already, but
> unfortunately I couldn't find that your reply again, sorry.
Since the common clock framework clk_prepare is mandatory.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
