On Mon, 2012-10-08 at 10:07 +0300, Tomi Valkeinen wrote: > Hi, > I don't see you setting disp->default_timing to OF_DEFAULT_TIMING in > case there's no default_timing found. > > Or, at least I presume OF_DEFAULT_TIMING is meant to mark non-existing > default timing. The name OF_DEFAULT_TIMING is not very descriptive to > me.
Ah, I see now from the second patch how this is meant to be used. So if there's no default timing in DT data, disp->default_timing is 0, meaning the first entry. And the caller of of_get_videomode() will use OF_DEFAULT_TIMING as index to get the default mode. So I think it's ok. Tomi
signature.asc
Description: This is a digitally signed message part
