Hi,
On Sat, Nov 15, 2014 at 04:18:59PM +0200, Sakari Ailus wrote:
...
> > union {
> > __s32 value;
> > __s64 value64;
> > @@ -1294,6 +1294,10 @@ struct v4l2_ext_control {
> > };
> > } __attribute__ ((packed));
> >
> > +/* v4l2_ext_control flags */
> > +#define V4L2_EXT_CTRL_FL_IGN_STORE_AFTER_USE 0x00000001
> > +#define V4L2_EXT_CTRL_FL_IGN_STORE 0x00000002
>
> Do we need both? Aren't these mutually exclusive, and you must have either
> to be meaningful in the context of a store?
Ah. Now I think I understand what do these mean. Please ignore my previous
comment.
I might call them differently. What would you think of
V4L2_EXT_CTRL_FL_STORE_IGNORE and V4L2_EXT_CTRL_FL_STORE_ONCE?
V4L2_EXT_CTRL_FL_IGN_STORE_AFTER_USE is quite long IMO. Up to you.
I wonder if we need EXT in V4L2_EXT_CTRL_FL. It's logical but also
redundant since the old control interface won't have flags either.
I'd assume that for cameras the vast majority of users will always want to
just apply the values once. How are the use cases in video decoding?
--
Regards,
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
