On Tuesday 17 March 2009 12:45:54 Michal Marek wrote:
> On Mon, Mar 09, 2009 at 03:59:17PM -0500, Mike Frysinger wrote:
> > On Monday 09 March 2009 14:48:59 Michal Marek wrote:
> > > @@ -20,7 +20,9 @@ AC_PROG_CC
> > >  AC_CHECK_PROGS(DOCBOOKTOMAN, docbook-to-man docbook2man, [no],)
> > >  if test x"$DOCBOOKTOMAN" = xno
> > >  then
> > > - AC_MSG_ERROR([docbook2man not found])
> > > + AC_MSG_WARN([docbook2man not found])
> > > + # fail with a meaningfull error if $DOCBOOKTOMAN called by the
> > > makefile +        DOCBOOKTOMAN=docbook2man
> > >  fi
> >
> > better to use the missing script from automake
>
> OK, updated patch attached
>
> Subject: [PATCH] Don't abort the build if docbook2man is missing
>
> Instead of aborting the build, print a warning if neither
> docbook2man nor docbook-to-man is found.
>
> Signed-off-by: Michal Marek <[email protected]>
> ---
>  configure.ac |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 9f09102..7b860b1 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -22,7 +22,9 @@ AC_PROG_CC
>  AC_CHECK_PROGS(DOCBOOKTOMAN, docbook-to-man docbook2man, [no],)
>  if test x"$DOCBOOKTOMAN" = xno
>  then
> -     AC_MSG_ERROR([docbook2man not found])
> +     AC_MSG_WARN([docbook2man not found])
> +     # fail with a meaningfull error if $DOCBOOKTOMAN called by the makefile

dont know if Jon cares, but some people prefer dnl for comments since the 
literal comment moved to configure is useless ...

> +     DOCBOOKTOMAN='${top_srcdir}/missing docbook2man'
>  fi

awesome, thanks ... i just wonder now if the /dev/null redirect that exists in 
the Makefile will prevent the pretty message from being displayed ?
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to