On Tue, 2010-08-10 at 14:16 +0200, ext Stanley.Miao wrote: > If we blank the panel by > echo 1 > /sys/devices/platform/omapfb/graphics/fb0/blank > > Then, we reboot the sytem, the kernel will crash at > drivers/video/omap2/dss/core.c:323 > > This is because the panel is closed twice. Now add a variable panel_enabled > to forbid a panel is power on or power off twice. > > Signed-off-by: Stanley.Miao <stanley.m...@windriver.com> > --- > drivers/video/omap2/displays/panel-generic.c | 11 +++++++++++ > .../video/omap2/displays/panel-sharp-lq043t1dg01.c | 11 +++++++++++ > .../video/omap2/displays/panel-sharp-ls037v7dw01.c | 11 +++++++++++ > drivers/video/omap2/displays/panel-taal.c | 6 ++++++ > .../video/omap2/displays/panel-toppoly-tdo35s.c | 11 +++++++++++ > .../video/omap2/displays/panel-tpo-td043mtea1.c | 9 +++++++++ > 6 files changed, 59 insertions(+), 0 deletions(-) > > diff --git a/drivers/video/omap2/displays/panel-generic.c > b/drivers/video/omap2/displays/panel-generic.c > index 300eff5..607f11a 100644 > --- a/drivers/video/omap2/displays/panel-generic.c > +++ b/drivers/video/omap2/displays/panel-generic.c > @@ -22,6 +22,8 @@ > > #include <plat/display.h> > > +static int panel_enabled;
While there's a revised version of this patch, I just wanted to point out that you can't use static variables in panel drivers, as there can be multiple devices using the same driver. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
