> -----Original Message-----
> From: Mike Frysinger [mailto:vap...@gentoo.org]
> Sent: den 31 oktober 2011 19:21
> To: Robert MARKLUND
> Cc: net...@vger.kernel.org; Steve Glendinning; Mathieu Poirier; Paul Mundt;
> linux...@vger.kernel.org;
> Sascha Hauer; Tony Lindgren; linux-omap@vger.kernel.org;
> uclinux-dist-de...@blackfin.uclinux.org;
> Linus Walleij
> Subject: Re: [PATCH 2/2 v4] net/smsc911x: Add regulator support
>
> On Monday 31 October 2011 08:38:39 Robert Marklund wrote:
> > ChangeLog v3->v4:
> > - Remove dual prints and old comment on Mike's request.
> > - Split the request_free fucntion on Mike and Sascha request.
>
> would be nice if the enable/disable were split as well ...
I interpret this as "nice if", if it's a "must be" then ill change it.
>
> > iounmap(pdata->ioaddr);
> >
> > + (void)smsc911x_enable_disable_resources(pdev, false);
>
> i don't think the (void) cast is necessary
I like telling the reader of the code that I ignore the return value,
I did not just forget it.
/R
>
> otherwise looks fine
> -mike
N�����r��y����b�X��ǧv�^�){.n�+����{��f��{ay� ʇڙ�,j��f���h���z� �w���
���j:+v���w�j�m��������zZ+�����ݢj"��!�i
