On Wed, Oct 31, 2012 at 04:56:40, Paul Walmsley wrote: > + Vaibhav Hiremath > > On Tue, 30 Oct 2012, Tony Lindgren wrote: > > > * Pantelis Antoniou <pa...@antoniou-consulting.com> [121030 11:04]: > > > Looks like the lcdc clock definition got dropped. > > > It is required for the LCD controller to work. Reintroduce. > > > > This looks like a regression, can you also add the commit > > causing it? > > Looks like probably a new "feature," in that this clock didn't exist in > the original check-in. Would be good to get Vaibhav's opinion on this; > also the common clock patches will need to be updated. >
Thanks Paul for looping me in, something went wrong with my l-o subscription, so I didn't receive these Patches. As far as lck clock node is concerned, we had deliberately dropped all leaf- node clocks from the clock tree, please refer to the description mentioned in - http://lists.infradead.org/pipermail/linux-arm-kernel/2012-May/101987.html >From LCDC driver perspective, driver is using, fb_clk = clk_get(&device->dev, NULL); This I feel needs to be corrected for valid name as per Spec (mostly I would vote for "fck") and then every platform should make sure that it returns valid clock-node for it. Change in Driver would be, fb_clk = clk_get(&device->dev, "fck"); Thanks, Vaibhav > > - Paul > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
